Skip to content

Add namespace correction workaround #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ehennestad wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add namespace correction workaround #782

ehennestad wants to merge 3 commits into from

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Jan 13, 2026 •
edited
Loading

Motivation

Fix issue reported in NWB helpesk:
NeurodataWithoutBorders/helpdesk#104

Some NWB files exist where the namespace of a neurodata type is written to file as core, but should be hdmf-common. This PR expands and generalizes the workaround from PR #779 to also correct core to hdmf-common if applicable.

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Update getNeurodataTypeInfo.m
6080c6e
@ehennestad
Update getNeurodataTypeInfo.m
ff96485 
Add workaround for issue where core namespace was written to file, but namespace should be hdmf_common
@ehennestad
Added unittest
3914ace
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.52%. Comparing base (b285920) to head (3914ace).

Files with missing lines Patch % Lines
+io/getNeurodataTypeInfo.m 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   95.53%   95.52%   -0.02%     
==========================================
  Files         191      191              
  Lines        6938     6944       +6     
==========================================
+ Hits         6628     6633       +5     
- Misses        310      311       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad requested a review from bendichter January 13, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bendichter bendichter Awaiting requested review from bendichter

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehennestad